Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sample.env generation in rlc-common for typespec-ts #2807

Closed
wants to merge 5 commits into from
Closed

Support sample.env generation in rlc-common for typespec-ts #2807

wants to merge 5 commits into from

Conversation

kazrael2119
Copy link
Contributor

fixes #2806

MaryGao
MaryGao reviewed Sep 10, 2024
View reviewed changes
packages/rlc-common/src/metadata/buildSampleEnvFile.ts

const sampleEnvText = `
# App registration secret for AAD authentication
AZURE_CLIENT_SECRET=
Copy link
Member

@MaryGao MaryGao Sep 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check if this is still recommanded?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file works well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HarshaNalluru could you hep check if tthis is expected as of the security concern of spring groove

MaryGao
MaryGao requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to verify if the env var works!

@kazrael2119 kazrael2119 mentioned this pull request Sep 29, 2024
Merged
@kazrael2119 kazrael2119 deleted the support-sampleenv branch September 29, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryGao MaryGao MaryGao requested changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support sample.env generation in rlc-common for typespec-ts
3 participants
@kazrael2119 @MaryGao @qiaozha